linux-kernel - Re: [PATCH v6 00/30] Refine PCI scan interfaces and make generic pci host bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150313113156.GA4739@bart.dudau.co.uk>
Date:	Fri, 13 Mar 2015 11:31:56 +0000
From:	Liviu Dudau <liviu@...au.co.uk>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	Yijing Wang <wangyijing@...wei.com>,
	Jiang Liu <jiang.liu@...ux.intel.com>,
	linux-pci@...r.kernel.org, Yinghai Lu <yinghai@...nel.org>,
	linux-kernel@...r.kernel.org, Marc Zyngier <marc.zyngier@....com>,
	linux-arm-kernel@...ts.infradead.org,
	Russell King <linux@....linux.org.uk>, x86@...nel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Tony Luck <tony.luck@...el.com>, linux-ia64@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Guan Xuetao <gxt@...c.pku.edu.cn>, linux-alpha@...r.kernel.org,
	linux-m68k@...ts.linux-m68k.org, Arnd Bergmann <arnd@...db.de>,
	Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH v6 00/30] Refine PCI scan interfaces and make generic pci
 host bridge

On Thu, Mar 12, 2015 at 04:23:06PM -0500, Bjorn Helgaas wrote:
> On Mon, Mar 09, 2015 at 10:33:57AM +0800, Yijing Wang wrote:
> > ...
> > Yijing Wang (29):
> >   PCI: Rip out pci_bus_add_devices() from pci_scan_bus()
> >   PCI: Rip out pci_bus_add_devices() from pci_scan_root_bus()
> >   sparc/PCI: Claim bus resources before pci_bus_add_devices()
> 
> I put the above patches plus a cleanup patch on my pci/enumeration branch.
> Please rebase your next revision to that.  If there's anything else
> non-controversial that we can pull in to chip away at this, let me know.

Hi Bjorn and Yijing,

Sorry for not providing feedback earlier on this series (or any previous ones),
I'm just crawling out from under a rock of doing graphics drivers :)

The patch ripping out pci_bus_add_devices() from pci_scan_root_bus() misses out
the users of that function from drivers/pci/host. If Yijing is going to refresh
the series it is probably worth starting with adding back the call into pcie-xilinx.c
and pci-versatile.c.

Will try to review (and test) the rest of the series soon.

Best regards,
Liviu

> 
> >   PCI: Export busn_resource to drivers/pci
> >   PCI: Remove deprecated pci_scan_bus_parented()
> >   PCI: Combine PCI domain and bus number in u32 arg
> >   PCI: Pass PCI domain number combined with root bus number
> >   PCI: Introduce pci_host_assign_domain_nr() to assign domain
> >   PCI: Separate pci_host_bridge creation out of pci_create_root_bus()
> >   PCI: Introduce pci_host_bridge_list to manage host bridges
> >   PCI: Save sysdata in pci_host_bridge drvdata
> >   PCI: Introduce pci_host_bridge_ops to support host specific
> >     operations
> >   PCI: Introduce new scan function pci_scan_host_bridge()
> >   x86/PCI: Refine pci_acpi_scan_root() with generic pci_host_bridge
> >   ia64/PCI: Refine pci_acpi_scan_root() with generic pci_host_bridge
> >   powerpc/pci: Rename pcibios_root_bridge_prepare()
> >   powerpc/pci: Use pci_scan_host_bridge() for simplicity
> >   PCI: Remove weak pcibios_root_bridge_prepare()
> >   sparc/PCI: Use pci_scan_host_bridge() for simplicity
> >   PCI: Introduce pci_bus_child_max_busnr()
> >   parisc/PCI: Use pci_scan_root_bus() for simplicity
> >   PCI/mvebu: Use pci_common_init_dev() to simplify code
> >   PCI/tegra: Remove redundant tegra_pcie_scan_bus()
> >   PCI/designware: Use pci_scan_root_bus() for simplicity
> >   PCI/xgene: Use pci_scan_root_bus() instead of pci_create_root_bus()
> >   PCI: Rename __pci_create_root_bus() to pci_create_root_bus()
> >   PCI: Export find_pci_host_bridge() and rename to
> >     pci_find_host_bridge()
> >   PCI: Remove platform specific pci_domain_nr()
> >   PCI: Remove pci_bus_assign_domain_nr()
> 

-- 
-------------------
   .oooO
   (   )
    \ (  Oooo.
     \_) (   )
          ) /
         (_/

 One small step
   for me ...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/