linux-kernel - Re: [PATCH] x86/kexec: Cleanup KEXEC_VERIFY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150313131324.GA21790@redhat.com>
Date:	Fri, 13 Mar 2015 09:13:24 -0400
From:	Vivek Goyal <vgoyal@...hat.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] x86/kexec: Cleanup KEXEC_VERIFY_SIG Kconfig help text

On Fri, Mar 13, 2015 at 02:04:37PM +0100, Borislav Petkov wrote:
> From: Borislav Petkov <bp@...e.de>
> 
> Make it much simpler without losing the gist of what it says.
> 
> Signed-off-by: Borislav Petkov <bp@...e.de>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Vivek Goyal <vgoyal@...hat.com>
> ---
>  arch/x86/Kconfig | 13 +++++--------
>  1 file changed, 5 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 8f829ffb9003..8db84b0e5bbd 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1775,14 +1775,11 @@ config KEXEC_VERIFY_SIG
>  	depends on KEXEC_FILE
>  	---help---
>  	  This option makes kernel signature verification mandatory for
> -	  kexec_file_load() syscall. If kernel is signature can not be
> -	  verified, kexec_file_load() will fail.
> -
> -	  This option enforces signature verification at generic level.
> -	  One needs to enable signature verification for type of kernel
> -	  image being loaded to make sure it works. For example, enable
> -	  bzImage signature verification option to be able to load and
> -	  verify signatures of bzImage. Otherwise kernel loading will fail.
> +	  the kexec_file_load() syscall.
> +
> +	  In addition to that option, you need to enable signature
> +	  verification for the corresponding kernel image type being
> +	  loaded in order for this to work.
>  

Hmm..., I find even previous text to be just fine. But as I wrote it, I
might be biased. So I will leave it to others to decide.

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/