linux-kernel - Re: [PATCH] of/selftest: remove the duplicate of_changeset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqLFG9BOjgHxuF17g2T3nkNBW+mh2L1kgKHu6JE5scBL2w@mail.gmail.com>
Date:	Fri, 13 Mar 2015 10:27:49 -0500
From:	Rob Herring <robherring2@...il.com>
To:	Wang Long <long.wanglong@...wei.com>
Cc:	Pantelis Antoniou <pantelis.antoniou@...sulko.com>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	peifeiyue@...wei.com
Subject: Re: [PATCH] of/selftest: remove the duplicate of_changeset_init

On Mon, Mar 2, 2015 at 12:49 AM, Wang Long <long.wanglong@...wei.com> wrote:
> Remove the duplicate of_changeset_init. In of_selftest_changeset
> testcase, the "struct of_changeset chgset" is initialized twice,
> but only once is enough. so, drop the first initializtion code.
>
> Signed-off-by: Wang Long <long.wanglong@...wei.com>

Applied for 4.0. Thanks.

Rob

> ---
>  drivers/of/unittest.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
> index 0cf9a23..199fb23 100644
> --- a/drivers/of/unittest.c
> +++ b/drivers/of/unittest.c
> @@ -478,7 +478,6 @@ static void __init of_selftest_changeset(void)
>         struct device_node *n1, *n2, *n21, *nremove, *parent, *np;
>         struct of_changeset chgset;
>
> -       of_changeset_init(&chgset);
>         n1 = __of_node_dup(NULL, "/testcase-data/changeset/n1");
>         selftest(n1, "testcase setup failure\n");
>         n2 = __of_node_dup(NULL, "/testcase-data/changeset/n2");
> --
> 1.8.3.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/