lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Mar 2015 17:17:36 -0700 From: Ray Jui <rjui@...adcom.com> To: Bjorn Helgaas <bhelgaas@...gle.com> CC: Arnd Bergmann <arnd@...db.de>, Hauke Mehrtens <hauke@...ke-m.de>, "Paul Bolle" <pebolle@...cali.nl>, Florian Fainelli <f.fainelli@...il.com>, Dmitry Torokhov <dtor@...gle.com>, Anatol Pomazau <anatol@...gle.com>, Scott Branden <sbranden@...adcom.com>, <linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, <bcm-kernel-feedback-list@...adcom.com>, <devicetree@...r.kernel.org> Subject: Re: [PATCH v6 3/4] pci: iproc: Add Broadcom iProc PCIe support On 3/12/2015 2:08 PM, Bjorn Helgaas wrote: > On Wed, Mar 11, 2015 at 11:06:08AM -0700, Ray Jui wrote: >> This adds the support for Broadcom iProc PCIe controller >> >> pcie-iproc.c servers as the common core driver, and front-end bus >> interface needs to be added to support different bus interfaces >> >> pcie-iproc-pltfm.c contains the support for the platform bus interface >> >> Signed-off-by: Ray Jui <rjui@...adcom.com> >> Reviewed-by: Scott Branden <sbranden@...adcom.com> >> ... > >> +static int iproc_pcie_check_link(struct iproc_pcie *pcie, struct pci_bus *bus) >> +{ >> + u8 hdr_type; >> + u32 link_ctrl; >> + u16 pos, link_status; >> + int link_is_active = 0; >> + >> + /* make sure we are not in EP mode */ >> + pci_bus_read_config_byte(bus, 0, PCI_HEADER_TYPE, &hdr_type); >> + if ((hdr_type & 0x7f) != PCI_HEADER_TYPE_BRIDGE) { >> + dev_err(pcie->dev, "in EP mode, hdr=0x08%x\n", hdr_type); > > "0x08%x" doesn't look right. I changed it to "%#02x"; is that what you > intended? > You are right. Will fix it along with the Kconfig fix (so it won't get compiled for non-ARM platforms). I'll submit v7? Thanks, Ray -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists