linux-kernel - Re: [PATCH] selftests/exec: take into account that zero is a success code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55030B4C.1080000@osg.samsung.com>
Date:	Fri, 13 Mar 2015 10:07:40 -0600
From:	Shuah Khan <shuahkh@....samsung.com>
To:	Andrey Vagin <avagin@...nvz.org>, linux-kernel@...r.kernel.org,
	Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH] selftests/exec: take into account that zero is a success
 code

On 03/13/2015 09:57 AM, Andrey Vagin wrote:
> Cc: Shuah Khan <shuahkh@....samsung.com>
> Signed-off-by: Andrey Vagin <avagin@...nvz.org>

Andrey,

Please add a meaningful commit log for this patch and resend.

-- Shuah
> ---
>  tools/testing/selftests/exec/execveat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/exec/execveat.c b/tools/testing/selftests/exec/execveat.c
> index e238c95..6747a3f 100644
> --- a/tools/testing/selftests/exec/execveat.c
> +++ b/tools/testing/selftests/exec/execveat.c
> @@ -47,7 +47,7 @@ static int _check_execveat_fail(int fd, const char *path, int flags,
>  		fd, path?:"(null)", flags, errno_str);
>  	rc = execveat_(fd, path, argv, envp, flags);
>  
> -	if (rc > 0) {
> +	if (rc >= 0) {
>  		printf("[FAIL] (unexpected success from execveat(2))\n");
>  		return 1;
>  	}
> 


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@....samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/