linux-kernel - Re: [rfc patch] rt,nohz_full: fix nohz_full for PREEMPT_RT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150312230329.6eb5fa98@gandalf.local.home>
Date:	Thu, 12 Mar 2015 23:03:29 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Mike Galbraith <umgwanakikbuti@...il.com>
Cc:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	linux-rt-users <linux-rt-users@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	John Kacur <jkacur@...hat.com>
Subject: Re: [rfc patch] rt,nohz_full: fix nohz_full for PREEMPT_RT_FULL

On Fri, 13 Mar 2015 03:13:15 +0100
Mike Galbraith <umgwanakikbuti@...il.com> wrote:

> > > +	int softirqd = IS_ENABLED(CONFIG_PREEMPT_RT_FULL);
> > > +
> > > +	softirqd &= current == this_cpu_ksoftirqd();
> > 
> > Ug, binary and logical ANDs should not be combined. Just looks nasty.
> > What about:
> > 
> > 	softirqd = !!(IS_ENABLED(CONFIG_PREEMPT_RT_FULL) &&
> > 			current == this_cpu_ksoftirqd());
> 
> My way looks prettier to me, but I seem to be the only who thinks so
> (this is not the first time it got a gripe), so I'll change it ;-)

I shouldn't have said it looks nasty. It actually does look pretty, in
an artistic kind of way. It's just not very comprehensible.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/