linux-kernel - Re: [PATCH v4 2/4] arm64: dts: Add Qualcomm MSM8916 SoC and evaluation board dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <91E83B79-5004-48C5-948B-7A9FD7F13BFE@codeaurora.org>
Date:	Fri, 13 Mar 2015 11:43:28 -0500
From:	Kumar Gala <galak@...eaurora.org>
To:	Mark Rutland <mark.rutland@....com>
Cc:	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"arm@...nel.org" <arm@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"heiko@...ech.de" <heiko@...ech.de>
Subject: Re: [PATCH v4 2/4] arm64: dts: Add Qualcomm MSM8916 SoC and evaluation board dts


On Mar 13, 2015, at 11:25 AM, Mark Rutland <mark.rutland@....com> wrote:

> On Fri, Mar 13, 2015 at 03:50:42PM +0000, Kumar Gala wrote:
>> 
>> On Mar 13, 2015, at 5:52 AM, Mark Rutland <mark.rutland@....com> wrote:
>> 
>>>> +/ {
>>>> +	chosen {
>>>> +		stdout-path = &blsp1_uart2;
>>>> +	};
>>> 
>>> It would be good if we had the configuration too (see
>>> Documentation/devicetree/bindings/chosen.txt), as that avoids any
>>> reliance on kernel defaults.
>>> 
>>> You can refer to an alias, so this could be:
>>> 
>>> aliases {
>>> 	serial0 = &blsp1_uart2;
>>> };
>>> 
>>> chosen {
>>> 	stdout-path = "serial0:115200n8";
>>> };
>>> 
>>> ...assuming that 115200n8 is correct for your UART, of course.
>>> 
>>> 
>>> […]
>> 
>> Where is the code that actually handles this parsing?  I’m not see it
>> in early_init_dt_scan_chosen_serial and I don’t believe
>> fdt_path_offset does anything special with ‘:'
> 
> Take a look at commit 7914a7c5651a5161 ("of: support passing console options with
> stdout-path").
> 
> Early on of_alias_scan will find the options and in of_console_check
> we'll call add_preferred_console as appropriate. That'll be called in
> uart_add_one_port.

Ok, but earlycon dt code doesn’t utilize this, as its setup is before we unflatten the dt.

So it breaks earlycon parsing right now, I’ll look at fixing that.

- k

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/