linux-kernel - Re: [PATCH] net/macb: Only adjust tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150312.230445.1330829248378823525.davem@davemloft.net>
Date:	Thu, 12 Mar 2015 23:04:45 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jaeden.amero@...com
Cc:	nicolas.ferre@...el.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, joshc@...com,
	soren.brinkmann@...inx.com
Subject: Re: [PATCH] net/macb: Only adjust tx_clk on link change

From: Jaeden Amero <jaeden.amero@...com>
Date: Thu, 12 Mar 2015 18:07:54 -0500

> The PHY state machine (in drivers/net/phy/phy.c) will unconditionally
> call phydev->adjust_link (macb_handle_link_change) when polling in the
> PHY_CHANGELINK state. As currently written, macb always ends up
> requesting a new tx_clk frequency in macb_handle_link_change. It is a
> waste of time to request a new tx_clk frequency if the link state hasn't
> changed, as the tx_clk will already be configured properly.
> 
> Let's only request a new tx_clk clock frequency when necessary.
> 
> Signed-off-by: Jaeden Amero <jaeden.amero@...com>

Applied to net-next, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/