linux-kernel - [PATCH] perf/builtin-diff: remove unnecessary error output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1426270754-11767-1-git-send-email-kuleshovmail@gmail.com>
Date:	Sat, 14 Mar 2015 00:19:14 +0600
From:	Alexander Kuleshov <kuleshovmail@...il.com>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Cc:	Alexander Kuleshov <kuleshovmail@...il.com>
Subject: [PATCH] perf/builtin-diff: remove unnecessary error output

This patch prevents duplicated error output. per_session__new function calls
perf_data_file__open which will print error message if it can not open the file
and we will get duplicated output of the error message:

failed to open perf.data.old: No such file or directory
Failed to open perf.data.old

Signed-off-by: Alexander Kuleshov <kuleshovmail@...il.com>
---
 tools/perf/builtin-diff.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
index 74aada5..a18bf98 100644
--- a/tools/perf/builtin-diff.c
+++ b/tools/perf/builtin-diff.c
@@ -742,7 +742,6 @@ static int __cmd_diff(void)
 	data__for_each_file(i, d) {
 		d->session = perf_session__new(&d->file, false, &tool);
 		if (!d->session) {
-			pr_err("Failed to open %s\n", d->file.path);
 			ret = -1;
 			goto out_delete;
 		}
-- 
2.3.1.291.g7a9409c

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/