linux-kernel - Re: [PATCH 9/9] tulip_core.c : out-of-bounds check.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55032F51.5090203@cogentembedded.com>
Date:	Fri, 13 Mar 2015 21:41:21 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Ameen Ali <ameenali023@...il.com>, grundler@...isc-linux.org
CC:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 9/9] tulip_core.c : out-of-bounds check.

Hello.

On 03/13/2015 05:15 PM, Ameen Ali wrote:

> Array index 'j' is used before limits check.

> Suggest put limit check before index use.

> Signed-off-by : <Ameenali023@...il.com>
> ---
>   drivers/net/ethernet/dec/tulip/tulip_core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c
> index 3b42556..ed41559 100644
> --- a/drivers/net/ethernet/dec/tulip/tulip_core.c
> +++ b/drivers/net/ethernet/dec/tulip/tulip_core.c
> @@ -589,7 +589,7 @@ static void tulip_tx_timeout(struct net_device *dev)
>   			       (unsigned int)tp->rx_ring[i].buffer1,
>   			       (unsigned int)tp->rx_ring[i].buffer2,
>   			       buf[0], buf[1], buf[2]);
> -			for (j = 0; buf[j] != 0xee && j < 1600; j++)
> +			for (j = 0; ((j < 1600) && buf[j] != 0xee); j++)

    No need for extra parens, either around < or around &&.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/