linux-kernel - Re: [PATCHv2] thermal: add omap3 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150313194025.GA22182@amd>
Date:	Fri, 13 Mar 2015 20:40:25 +0100
From:	Pavel Machek <pavel@....cz>
To:	Eduardo Valentin <edubezval@...il.com>
Cc:	rui.zhang@...el.com, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org, linux-omap@...r.kernel.org,
	pali.rohar@...il.com, sre@...ian.org, sre@...g0.de,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	tony@...mide.com, khilman@...nel.org, aaro.koskinen@....fi,
	ivo.g.dimitrov.75@...il.com
Subject: Re: [PATCHv2] thermal: add omap3 support

Hi!

> > @@ -384,25 +385,10 @@ int ti_bandgap_set_sensor_data(struct ti_bandgap *bgp, int id, void *data);
> >  void *ti_bandgap_get_sensor_data(struct ti_bandgap *bgp, int id);
> >  int ti_bandgap_get_trend(struct ti_bandgap *bgp, int id, int *trend);
> >  
> > -#ifdef CONFIG_OMAP4_THERMAL
> > +extern const struct ti_bandgap_data omap34xx_data;
> >  extern const struct ti_bandgap_data omap4430_data;
> >  extern const struct ti_bandgap_data omap4460_data;
> >  extern const struct ti_bandgap_data omap4470_data;
> > -#else
> > -#define omap4430_data					NULL
> > -#define omap4460_data					NULL
> > -#define omap4470_data					NULL
> > -#endif
> > -
> > -#ifdef CONFIG_OMAP5_THERMAL
> >  extern const struct ti_bandgap_data omap5430_data;
> > -#else
> > -#define omap5430_data					NULL
> > -#endif
> > -
> > -#ifdef CONFIG_DRA752_THERMAL
> >  extern const struct ti_bandgap_data dra752_data;
> > -#else
> > -#define dra752_data					NULL
> > -#endif
> 
> Pavel,
> 
> Why do we need to remove the existing symbols for other chips in this file to get OMAP3 support in?
> 

No, I don't need to remove this, and you can safely drop this hunk.

OTOH those ifdefs are unneccessary and eye-sore: extern symbol
declarations do not really hurt, and .c files already contain enough
#ifdefs for other reasons that the symbols will not be needed when it
is not configured.

Try it, it should work ok.

Best regards,
								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/