linux-kernel - [PATCH] selftests: check that execveat returns negative values in case of errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1426277992-24853-1-git-send-email-avagin@openvz.org>
Date:	Fri, 13 Mar 2015 23:19:52 +0300
From:	Andrey Vagin <avagin@...nvz.org>
To:	linux-kernel@...r.kernel.org
Cc:	Andrey Vagin <avagin@...nvz.org>,
	Shuah Khan <shuahkh@....samsung.com>
Subject: [PATCH] selftests: check that execveat returns negative values in case of errors

Currently we check that execveat returns non-positive value
when an error is expected. But we need to check that execveat() doesn't
return zero in such cases too.

Cc: Shuah Khan <shuahkh@....samsung.com>
Signed-off-by: Andrey Vagin <avagin@...nvz.org>
---
 tools/testing/selftests/exec/execveat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/exec/execveat.c b/tools/testing/selftests/exec/execveat.c
index e238c95..6747a3f 100644
--- a/tools/testing/selftests/exec/execveat.c
+++ b/tools/testing/selftests/exec/execveat.c
@@ -47,7 +47,7 @@ static int _check_execveat_fail(int fd, const char *path, int flags,
 		fd, path?:"(null)", flags, errno_str);
 	rc = execveat_(fd, path, argv, envp, flags);
 
-	if (rc > 0) {
+	if (rc >= 0) {
 		printf("[FAIL] (unexpected success from execveat(2))\n");
 		return 1;
 	}
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/