linux-kernel - Re: [PATCH 12/12] crypto/sha-mb/sha1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1426282398.660.22.camel@schen9-desk2.jf.intel.com>
Date:	Fri, 13 Mar 2015 14:33:18 -0700
From:	Tim Chen <tim.c.chen@...ux.intel.com>
To:	Ameen Ali <ameenali023@...il.com>
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH 12/12] crypto/sha-mb/sha1_mb.c : Syntax error

On Fri, 2015-03-13 at 23:13 +0200, Ameen Ali wrote:
> fixing a syntax-error .
> 
> Signed-off-by : Ameen Ali <AmeenAli023@...il.com>
> ---
>  arch/x86/crypto/sha-mb/sha1_mb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/crypto/sha-mb/sha1_mb.c b/arch/x86/crypto/sha-mb/sha1_mb.c
> index fd9f6b0..ec0b989 100644
> --- a/arch/x86/crypto/sha-mb/sha1_mb.c
> +++ b/arch/x86/crypto/sha-mb/sha1_mb.c
> @@ -828,7 +828,7 @@ static unsigned long sha1_mb_flusher(struct mcryptd_alg_cstate *cstate)
>  	while (!list_empty(&cstate->work_list)) {
>  		rctx = list_entry(cstate->work_list.next,
>  				struct mcryptd_hash_request_ctx, waiter);
> -		if time_before(cur_time, rctx->tag.expire)
> +		if(time_before(cur_time, rctx->tag.expire))

Can you add a space and make it 
		if (time_before(cur_time, rctx->tag.expire))

Thanks.

Tim
>  			break;
>  		kernel_fpu_begin();
>  		sha_ctx = (struct sha1_hash_ctx *) sha1_ctx_mgr_flush(cstate->mgr);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/