linux-kernel - [PATCH 14/16] staging: rtl8723au: Improve readability of two very long lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1426216532-24058-15-git-send-email-m.v.b@runbox.com>
Date:	Thu, 12 Mar 2015 23:15:30 -0400
From:	"M. Vefa Bicakci" <m.v.b@...box.com>
To:	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org
Cc:	m.v.b@...box.com
Subject: [PATCH 14/16] staging: rtl8723au: Improve readability of two very long lines

Improve the readability of an if statement and its very long trace
output line in rtl8723au's rtw_security.c.

Signed-off-by: M. Vefa Bicakci <m.v.b@...box.com>
---
 drivers/staging/rtl8723au/core/rtw_security.c | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c
index dbbe7b348d..fd04ae78bb 100644
--- a/drivers/staging/rtl8723au/core/rtw_security.c
+++ b/drivers/staging/rtl8723au/core/rtw_security.c
@@ -759,9 +759,21 @@ int rtw_tkip_decrypt23a(struct rtw_adapter *padapter,
 
 	*((u32 *)crc) = le32_to_cpu(getcrc32(payload, length-4));
 
-	if (crc[3] != payload[length - 1] || crc[2] != payload[length - 2] || crc[1] != payload[length - 3] || crc[0] != payload[length - 4]) {
-		RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("rtw_wep_decrypt23a:icv error crc[3](%x)!= payload[length-1](%x) || crc[2](%x)!= payload[length-2](%x) || crc[1](%x)!= payload[length-3](%x) || crc[0](%x)!= payload[length-4](%x)\n",
-				crc[3], payload[length - 1], crc[2], payload[length - 2], crc[1], payload[length - 3], crc[0], payload[length - 4]));
+	if (crc[3] != payload[length - 1] ||
+			crc[2] != payload[length - 2] ||
+			crc[1] != payload[length - 3] ||
+			crc[0] != payload[length - 4]) {
+
+		RT_TRACE(_module_rtl871x_security_c_, _drv_err_,
+				("rtw_wep_decrypt23a:icv error "
+				 "crc[3](%x)!= payload[length-1](%x) || "
+				 "crc[2](%x)!= payload[length-2](%x) || "
+				 "crc[1](%x)!= payload[length-3](%x) || "
+				 "crc[0](%x)!= payload[length-4](%x)\n",
+				 crc[3], payload[length - 1],
+				 crc[2], payload[length - 2],
+				 crc[1], payload[length - 3],
+				 crc[0], payload[length - 4]));
 		res = _FAIL;
 	}
 
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/