linux-kernel - Re: [PATCH] parisc: fix pmd accounting with 3-level page tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 14 Mar 2015 08:20:08 +1030
From:	Graham Gower <graham.gower@...il.com>
To:	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	linux-parisc <linux-parisc@...r.kernel.org>,
	John David Anglin <dave.anglin@...l.net>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	Domenico Andreoli <cavokz@...il.com>
Subject: Re: [PATCH] parisc: fix pmd accounting with 3-level page tables

This fixes the problem on my C8000.

Tested-by: graham.gower@...il.com

On 13 March 2015 at 21:00, Kirill A. Shutemov
<kirill.shutemov@...ux.intel.com> wrote:
> There's hack in pgd_alloc() on parisc to initialize one pmd, which is
> not accounted. It leads to underflow on exit.
>
> Let's adjust nr_pmds on pgd_alloc() to get accounting correct.
>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> Cc: John David Anglin <dave.anglin@...l.net>
> Cc: Aaro Koskinen <aaro.koskinen@....fi>
> Cc: Graham Gower <graham.gower@...il.com>
> Cc: Domenico Andreoli <cavokz@...il.com>
> ---
>  arch/parisc/include/asm/pgalloc.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/parisc/include/asm/pgalloc.h b/arch/parisc/include/asm/pgalloc.h
> index 55ad8be9b7f3..068b2fb9a47c 100644
> --- a/arch/parisc/include/asm/pgalloc.h
> +++ b/arch/parisc/include/asm/pgalloc.h
> @@ -38,6 +38,7 @@ static inline pgd_t *pgd_alloc(struct mm_struct *mm)
>                 /* The first pmd entry also is marked with _PAGE_GATEWAY as
>                  * a signal that this pmd may not be freed */
>                 __pgd_val_set(*pgd, PxD_FLAG_ATTACHED);
> +               mm_inc_nr_pmds(mm);
>  #endif
>         }
>         return actual_pgd;
> --
> 2.1.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/