linux-kernel - Re: [PATCH] checkpatch: match more world writable permissions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150314143200.GA19645@roeck-us.net>
Date:	Sat, 14 Mar 2015 07:32:00 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Joe Perches <joe@...ches.com>
Cc:	Nicholas Mc Guire <hofrat@...dl.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andy Whitcroft <apw@...onical.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: match more world writable permissions

On Fri, Mar 13, 2015 at 04:43:43PM -0700, Joe Perches wrote:
> Currently checkpatch will fuss if one uses world writable
> settings in debugfs files and DEVICE_ATTR uses by testing
> S_IWUGO but not testing S_IWOTH, S_IRWXUGO or S_IALLUGO.
> 
> Extend the check to catch all cases exporting world writable
> permissions including octal values.
> 
> Original-patch-by: Nicholas Mc Guire <hofrat@...dl.org>
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  scripts/checkpatch.pl | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 6b79beb..4f07d50 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -443,6 +443,14 @@ foreach my $entry (@mode_permission_funcs) {
>  	$mode_perms_search .= $entry->[0];
>  }
>  
> +$our $mode_perms_world_writable = qr{
> +	S_IWUGO		|
> +	S_IWOTH		|
> +	S_IRWXUGO	|
> +	S_IALLUGO	|
> +	0[0-7][0-7][2367]
> +}x;
> +
>  our $allowed_asm_includes = qr{(?x:
>  	irq|
>  	memory|
> @@ -5356,8 +5364,8 @@ sub process {
>  			}
>  		}
>  
> -		if ($line =~ /debugfs_create_file.*S_IWUGO/ ||
> -		    $line =~ /DEVICE_ATTR.*S_IWUGO/ ) {
> +		if ($line =~ /debugfs_create_\w+.*\b$mode_perms_world_writable\b/ ||
> +		    $line =~ /DEVICE_ATTR.*\b$mode_perms_world_writable\b/) {
>  			WARN("EXPORTED_WORLD_WRITABLE",
>  			     "Exporting world writable files is usually an error. Consider more restrictive permissions.\n" . $herecurr);

With https://lkml.org/lkml/2015/3/12/412 in mind, maybe this should be
marked as error, at least for sysfs attributes.

Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/