linux-kernel - Re: [PATCH 2/5 linux-next] udf: use sector_t for udf_bitmap_prealloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 14 Mar 2015 07:39:06 +0100
From:	Jan Kara <jack@...e.cz>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel@...r.kernel.org, Jan Kara <jack@...e.cz>
Subject: Re: [PATCH 2/5 linux-next] udf: use sector_t for
 udf_bitmap_prealloc_blocks() return value

On Tue 10-03-15 21:44:32, Fabian Frederick wrote:
> udf_bitmap_prealloc_blocks() can only return positive value and is only
> used to assign sector_t allocated.
  The return value is number of allocated blocks. There's no good reason to
change that to sector_t... The variable 'allocated' in
udf_prealloc_blocks() could be int if anything.

								Honza
> 
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  fs/udf/balloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/udf/balloc.c b/fs/udf/balloc.c
> index 02948f0..30f4641 100644
> --- a/fs/udf/balloc.c
> +++ b/fs/udf/balloc.c
> @@ -170,7 +170,7 @@ error_return:
>  	mutex_unlock(&sbi->s_alloc_mutex);
>  }
>  
> -static int udf_bitmap_prealloc_blocks(struct super_block *sb,
> +static sector_t udf_bitmap_prealloc_blocks(struct super_block *sb,
>  				      struct udf_bitmap *bitmap,
>  				      uint16_t partition, uint32_t first_block,
>  				      uint32_t block_count)
> -- 
> 1.9.1
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/