linux-kernel - Re: [PATCH v3] mmc: OCTEON: Add host driver for OCTEON MMC controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150315183701.GB586@fuloong-minipc.musicnaut.iki.fi>
Date:	Sun, 15 Mar 2015 20:37:01 +0200
From:	Aaro Koskinen <aaro.koskinen@....fi>
To:	Aleksey Makarov <aleksey.makarov@...iga.com>
Cc:	linux-mmc@...r.kernel.org, linux-mips@...ux-mips.org,
	linux-kernel@...r.kernel.org, David Daney <david.daney@...ium.com>,
	Leonid Rosenboim <lrosenboim@...iumnetworks.com>,
	Aaron Williams <aaron.williams@...ium.com>,
	Chandrakala Chavva <cchavva@...iumnetworks.com>,
	Peter Swain <pswain@...ium.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Chris Ball <chris@...ntf.net>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v3] mmc: OCTEON: Add host driver for OCTEON MMC controller

Hi,

On Thu, Mar 05, 2015 at 05:50:31PM +0300, Aleksey Makarov wrote:
> The OCTEON MMC controller is currently found on cn61XX and cnf71XX
> devices.  Device parameters are configured from device tree data.
> 
> eMMC, MMC and SD devices are supported.
> 
> Signed-off-by: David Daney <david.daney@...ium.com>
> Signed-off-by: Leonid Rosenboim <lrosenboim@...iumnetworks.com>
> Signed-off-by: Aaron Williams <aaron.williams@...ium.com>
> Signed-off-by: Chandrakala Chavva <cchavva@...iumnetworks.com>
> Signed-off-by: Peter Swain <pswain@...ium.com>
> [aleksey.makarov@...iga.com: preparation for submission]
> Signed-off-by: Aleksey Makarov <aleksey.makarov@...iga.com>

Seems to work fine on EdgeRouter Pro (cn61xx).

Tested-by: Aaro Koskinen <aaro.koskinen@....fi>

However, there is a sparse warning that probably needs to be fixed:

	octeon_mmc.c:1141:29: error: incompatible types for operation (>=)
	octeon_mmc.c:1141:29:    left side has type struct gpio_desc *pwr_gpiod
	octeon_mmc.c:1141:29:    right side has type int

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/