linux-kernel - Re: [PATCH v3 1/5] i8042: intel-8042 DT documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150315032038.GA13064@dtor-ws>
Date:	Sat, 14 Mar 2015 20:20:38 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Roman Volkov <v1ron@...os.org>
Cc:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Grant Likely <grant.likely@...aro.org>,
	Hans de Goede <hdegoede@...hat.com>,
	Jiri Kosina <jkosina@...e.cz>,
	Wolfram Sang <wsa@...-dreams.de>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	Tony Prisk <linux@...sktech.co.nz>
Subject: Re: [PATCH v3 1/5] i8042: intel-8042 DT documentation

Hi Roman,

On Mon, Feb 16, 2015 at 12:11:43AM +0300, Roman Volkov wrote:
> Documentation for 'intel,8042' DT compatible node.
> 
> Signed-off-by: Tony Prisk <linux@...sktech.co.nz>
> Signed-off-by: Roman Volkov <v1ron@...os.org>
> ---
>  .../devicetree/bindings/input/intel-8042.txt       | 26 ++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/intel-8042.txt
> 
> diff --git a/Documentation/devicetree/bindings/input/intel-8042.txt b/Documentation/devicetree/bindings/input/intel-8042.txt
> new file mode 100644
> index 0000000..ab8a3e0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/intel-8042.txt
> @@ -0,0 +1,26 @@
> +Intel 8042 Keyboard Controller
> +
> +Required properties:
> +- compatible: should be "intel,8042"
> +- regs: memory for keyboard controller
> +- interrupts: usually, two interrupts should be specified (keyboard and aux).
> +	However, only one interrupt is also allowed in case of absence of the
> +	physical port in the controller. The i8042 driver must be loaded with
> +	nokbd/noaux option in this case.
> +- interrupt-names: interrupt names corresponding to numbers in the list.
> +	"kbd" is the keyboard interrupt and "aux" is the auxiliary (mouse)
> +	interrupt.
> +- command-reg: offset in memory for command register
> +- status-reg: offset in memory for status register
> +- data-reg: offset in memory for data register
> +
> +Example:
> +	i8042@...08800 {
> +		compatible = "intel,8042";
> +		regs = <0xd8008800 0x100>;
> +		interrupts = <23>, <4>;
> +		interrupt-names = "kbd", "aux";
> +		command-reg = <0x04>;
> +		status-reg = <0x04>;
> +		data-reg = <0x00>;
> +	};

No, we already have existing OF bindings for i8042 on sparc and powerpc,
I do not think we need to invent a brand new one.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/