linux-kernel - Re: [PATCH v4 5/5] ARM: dts: Add LEDs to exynos5410-odroidxu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Mar 2015 09:02:05 +0100
From:	Javier Martinez Canillas <javier@...hile0.org>
To:	Andreas Färber <afaerber@...e.de>
Cc:	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>, Kukjin Kim <kgene@...nel.org>,
	김학주 <ruppi.kim@...dkernel.com>,
	Tomasz Figa <tomasz.figa@...il.com>,
	Humberto Naves <hsnaves@...il.com>,
	Jan Kiszka <jan.kiszka@...mens.com>,
	Johann Pfefferl <johann.pfefferl@...mens.com>,
	Ben Gamari <bgamari.foss@...il.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 5/5] ARM: dts: Add LEDs to exynos5410-odroidxu

Hello Andreas,

On Sun, Mar 15, 2015 at 11:00 PM, Andreas Färber <afaerber@...e.de> wrote:
> Signed-off-by: Hakjoo Kim <ruppi.kim@...dkernel.com>
> Signed-off-by: Andreas Färber <afaerber@...e.de>
> ---
>  v2 -> v3: Unchanged
>
>  v1 -> v2:
>  * Filled in Sob from Hakjoo Kim
>
>  arch/arm/boot/dts/exynos5410-odroidxu.dts | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts
> index 97310bb727e2..b02cd3ab7b38 100644
> --- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
> +++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
> @@ -15,6 +15,7 @@
>
>  /dts-v1/;
>  #include "exynos5410.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
>  / {
>         model = "ODROID-XU based on EXYNOS5410";
>         compatible = "hardkernel,odroid-xu", "samsung,exynos5410", "samsung,exynos5";
> @@ -39,6 +40,30 @@
>                 reg = <0x02037000 0x1000>;
>         };
>
> +       leds {
> +               compatible = "gpio-leds";
> +
> +               blue {
> +                       label = "blue:heartbeat";
> +                       gpios = <&gpb2 2 GPIO_ACTIVE_HIGH>;
> +                       default-state = "off";
> +                       linux,default-trigger = "heartbeat";
> +               };
> +
> +               green {
> +                       label = "green:activity";
> +                       gpios = <&gpb2 1 GPIO_ACTIVE_HIGH>;
> +                       default-state = "off";
> +                       linux,default-trigger = "mmc0";
> +               };
> +
> +               red {
> +                       label = "red:activity";
> +                       gpios = <&gpx2 3 GPIO_ACTIVE_HIGH>;
> +                       default-state = "off";
> +                       linux,default-trigger = "mmc1";
> +               };

I see that you are sorting alphabetically using the node name but for
example in pinctrl lines we were sorting using the GPIO bank and
offset so if we want to use the same policy here, this should be
green, blue and red.

Either way is good to me though so is up to you.

Reviewed-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk>

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/