linux-kernel - Re: [PATCH 1/3] tile/elf: reorganize notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5507379E.8000607@ezchip.com>
Date:	Mon, 16 Mar 2015 16:05:50 -0400
From:	Chris Metcalf <cmetcalf@...hip.com>
To:	Davidlohr Bueso <dave@...olabs.net>, <akpm@...ux-foundation.org>
CC:	<linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
	Davidlohr Bueso <dbueso@...e.de>
Subject: Re: [PATCH 1/3] tile/elf: reorganize notify_exec()

On 2/25/2015 4:58 PM, Davidlohr Bueso wrote:
> In the future mm->exe_file will be done without mmap_sem
> serialization, thus isolate and reorganize the tile elf
> code to make the transition easier. Good users will, make
> use of the more standard get_mm_exe_file(), requiring only
> holding the mmap_sem to read the value, and relying on reference
> counting to make sure that the exe file won't dissappear
> underneath us.
>
> The visible effects of this patch are:
>
>     o We now take and drop the mmap_sem more often. Instead of
>       just in arch_setup_additional_pages(), we also do it in:
>
>       1) get_mm_exe_file()
>       2) to get the mm->vm_file and notify the simulator.
>
>      [Note that 1) will disappear once we change the locking
>       rules for exe_file.]
>
>     o We avoid getting a free page and doing d_path() while
>       holding the mmap_sem. This requires reordering the checks.
>
> Cc: Chris Metcalf<cmetcalf@...hip.com>
> Signed-off-by: Davidlohr Bueso<dbueso@...e.de>
> ---
>
> completely untested.
>
>   arch/tile/mm/elf.c | 47 +++++++++++++++++++++++++++++------------------
>   1 file changed, 29 insertions(+), 18 deletions(-)

This looks OK to me and passes basic testing.  So here is my

Acked-by: Chris Metcalf <cmetcalf@...hip.com>

Or would you prefer I took this through the tile tree?

-- 
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/