linux-kernel - Re: [PATCH] Add a quirk for the Dell XPS 13 (2015) when in PS/2 mode.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAN+gG=Hg7u27PXryAt37+dgvwr4SHG9Bf_woNNxd7=nQVvZDAA@mail.gmail.com>
Date:	Mon, 16 Mar 2015 17:07:09 -0400
From:	Benjamin Tissoires <benjamin.tissoires@...il.com>
To:	Jason Ekstrand <jason@...kstrand.net>
Cc:	Mario Limonciello <mario_limonciello@...l.com>,
	Pali Rohár <pali.rohar@...il.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	Rob <robr.bensson@...il.com>
Subject: Re: [PATCH] Add a quirk for the Dell XPS 13 (2015) when in PS/2 mode.

On Mon, Mar 16, 2015 at 4:57 PM, Jason Ekstrand <jason@...kstrand.net> wrote:
> On Mon, Mar 16, 2015 at 1:50 PM, Mario Limonciello
> <mario_limonciello@...l.com> wrote:
>>
>> On 03/16/2015 03:42 PM, Jason Ekstrand wrote:
>>>
>>> On Mon, Mar 16, 2015 at 11:50 AM, Mario Limonciello
>>> <mario_limonciello@...l.com> wrote:
>>> Thanks,
>>> I'm now running a hacked up kernel that's Torvalds' tree from Saturday
>>> morning (same as before) + a patch from Benjamin to fix the touchpad +
>>> the DSDT hack given above.  With that, I have HDA audio (not I2S)
>>> which is working.  Also, suspend/resume now works properly with this
>>> new cocktail.
>>> --Jason
>>
>> That's great to hear and definitely confirms that it was the sound card in
>> the funky state causing the suspend/resume issues.  Testing is ongoing with
>> that BIOS and if no issues crop up should be around soon.
>
> Thanks!  I look forwarding to *not* running a hacked-up kernel soon.
>
>> Is this the patch from Benjamin that you're running?
>> http://pkgs.fedoraproject.org/cgit/kernel.git/commit/?h=f21&id=d75cb059558345e47a13881512a1600e3e17ba21
>> I haven't yet run it myself.  I'm curious, what sort of behavior change do
>> you see with it?
>
> It reports as touchpad with a single button.  This makes the kernel
> report it as a "clickpad".  In particular, this means that libinput
> knows to make clicking in the lower-right turn into a right-click.
> With out that, there was no way to right-click since it reports as
> having a single button.  Benjamin could tell you more than me.

Yes, that's the gist of it.
Mario, you might not have seen the problem because you are not running
wayland and/or libinput. The xorg synaptics driver is much more
relaxed concerning what it received from the kernel and I think it
sets most of the time the right software button area if it sees only
one button.

Cheers,
Benjamin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/