linux-kernel - Re: [git pull] gadgetfs fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5506AC65.4030703@ahsoftware.de>
Date:	Mon, 16 Mar 2015 11:11:49 +0100
From:	Alexander Holler <holler@...oftware.de>
To:	Al Viro <viro@...IV.linux.org.uk>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [git pull] gadgetfs fixes

Am 15.03.2015 um 09:31 schrieb Alexander Holler:
> Am 15.03.2015 um 09:17 schrieb Al Viro:
>> On Sun, Mar 15, 2015 at 07:35:20AM +0100, Alexander Holler wrote:
>>
>>>> Umm...  If I'm not misparsing what you said, you are talking about the
>>>
>>> Glücklicherweise nicht. Vielleicht sollten wir es zur Abwechslung mal
>>> mit meiner bevorzugten Sprache versuchen.
>>
>> Good.  I'll probably abstain from trying to mangle it, though.
>>
>> Another question, if you don't mind - does that series (i.e. what's
>> currently
>> in Linus' tree) fix the module refcount issues you'd been seeing?  I
>> agree
>> with your analysis of likely cause (->f_op reassignments with different
>> ->owner before and after) and these patches should have eliminated
>> that, but
>> confirmation would be nice...
>
> I haven't tried to apply the whole series to the 3.19.1 which I'm
> currently using. As mentioned before, something (a single patch I've
> tried before) didn't apply cleanly which means I need to have a deeper
> look at the stuff. E.g. I've just learned (through another problem),
> that (my version of) glibc still doesn't use the aio-syscalls the kernel
> provides (and instead uses pread/pwrite).
>
> I will look if I find the time today.

Also it's already merged, looks good. Please just don't forget to add that

value = -ENOMEM;

if commit f01d35a1 goes down the road without the following patches.

Thanks,

Alexander Holler


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/