linux-kernel - Re: [PATCH] printk: Use symbolic defines for console loglevels instead of numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANCZXo6xO+4_740VE2v7NZT2XVrcpfDPM5DZe2wVs0bgp50rfQ@mail.gmail.com>
Date:	Mon, 16 Mar 2015 16:50:14 +0600
From:	Alexander Kuleshov <kuleshovmail@...il.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] printk: Use symbolic defines for console loglevels
 instead of numbers

Hello Geert,

Yes, i thougt about this issue. I looked in git history and found the
commit - a8fe19ebfbfd90ec17c02284717238b02efb9580 where level 8
changed on 10,
so i decided to put CONSOLE_LOGLEVEL_DEBUG here.


2015-03-16 15:20 GMT+06:00 Geert Uytterhoeven <geert@...ux-m68k.org>:
> On Mon, Mar 16, 2015 at 10:01 AM, Alexander Kuleshov
> <kuleshovmail@...il.com> wrote:
>> --- a/arch/m68k/mac/macints.c
>> +++ b/arch/m68k/mac/macints.c
>> @@ -315,7 +315,7 @@ irqreturn_t mac_nmi_handler(int irq, void *dev_id)
>>         while (nmi_hold == 1)
>>                 udelay(1000);
>>
>> -       if (console_loglevel >= 8) {
>> +       if (console_loglevel >= CONSOLE_LOGLEVEL_DEBUG) {
>
> CONSOLE_LOGLEVEL_DEBUG == 10, not 8
>
> As there's no define for 8, perhaps you can use:
>
> "if (console_loglevel > CONSOLE_LOGLEVEL_DEFAULT) {"
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/