linux-kernel - kexec fails if OF_UNITTEST=y (was: Re: [PATCH v2] Removes OF_UNITTEST dependency on OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVb47ogpLe_4iSz-NAxdcASUZ2HzTpxh+ibjcdMtiO-tQ@mail.gmail.com>
Date:	Mon, 16 Mar 2015 11:58:57 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Gaurav Minocha <gaurav.minocha.os@...il.com>
Cc:	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <rob.herring@...aro.org>,
	kexec@...ts.infradead.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: kexec fails if OF_UNITTEST=y (was: Re: [PATCH v2] Removes OF_UNITTEST
 dependency on OF_DYNAMIC config symbol)

On Fri, Jan 23, 2015 at 2:03 PM, Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
> On Sun, Jan 11, 2015 at 8:19 AM, Gaurav Minocha
> <gaurav.minocha.os@...il.com> wrote:
>> This patch intends to remove the unittests dependency on
>> the functions defined in dynamic.c. So, rather than calling
>> of_attach_node defined in dynamic.c, minimal functionality
>> required to attach a new node is re-defined in unittest.c.
>> Also, now after executing the tests the test data is not
>> removed from the device tree so there is no need to call
>> of_detach_node.
>
> Could there be unwanted side effects of not removing the test data?

Unfortunately I found a regression introduced by commit 3ce04b4a9fdc30b6
("Removes OF_UNITTEST dependency on OF_DYNAMIC config symbol").

If the test data is still present, kexec (kexec-tools 2.0.7 released 24
November 2014, 1:2.0.7-5 in Debian) fails with:

unrecoverable error: short read
from"/proc/device-tree//testcase-data/large-property-PAGE_SIZEx8"

Granted, this is a bug in kexec-tools, but I'm reporting it anyway, as it is
a kernel regression with existing userspace.

I believe this bug was fixed in kexec-tools by commit d1932cd592e2a6aa
("kexec/fs2dt: Use slurp_file_len to avoid partial read of files"), but I
haven't tested the fix yet.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/