linux-kernel - Re: [PATCH] staging:sm750fb:Fixed no space and indent warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 16 Mar 2015 19:38:39 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Ragavendra Nagraj <ragavendra.bn@...il.com>
Cc:	teddy.wang@...iconmotion.com, gregkh@...uxfoundation.org,
	linux-fbdev@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging:sm750fb:Fixed no space and indent warnings

On Sun, Mar 15, 2015 at 05:21:09PM -0700, Ragavendra Nagraj wrote:
the convention to write the subject is :
staging: sm750fb: your subject line
this is for all drivers, if you see the mails in lkml you will see
that almost everyone follows the same convention.

> 
> Signed-off-by: Ragavendra Nagraj <ragavendra.bn@...il.com>
> ---
<snip>
>  
>  unsigned int getPllValue(clock_type_t clockType, pll_value_t *pPLL)
>  {
> -    unsigned int ulPllReg = 0;
> -
> -    pPLL->inputFreq = DEFAULT_INPUT_CLOCK;
> -    pPLL->clockType = clockType;
> -
> -    switch (clockType)
> -    {
> -        case MXCLK_PLL:
> -            ulPllReg = PEEK32(MXCLK_PLL_CTRL);
> -            break;
<snip>
> +
> +	switch (clockType)
> +	{
> +	case MXCLK_PLL:
> +		ulPllReg = PEEK32(MXCLK_PLL_CTRL);
> +		break;
you changed the switch-case indention here in this function. but you
have not changed the switch-case indention in the function
setMemoryClock() or in setMasterClock() later in your patch.
but again changed the indention in the function ddk750_getVMSize().
any reason? was that intentional?

> +	case PRIMARY_PLL:
<snip>
> -
> -        /* Master Clock Control: MXCLK_PLL */
> -        POKE32(MXCLK_PLL_CTRL, formatPllReg(&pll));
> -    }
> +	if (frequency != 0)
> +		{
an extra tab came here.	
> +		/*
<snip>		   
>  #ifdef VALIDATION_CHIP
> -                        if (OD > 2)
> -                            POD = 2;
> -                        else
> -                            POD = OD;
> +			if (OD > 2)
> +				POD = 2;
> +			else
> +				POD = OD;
>  #endif
>  
> -                        pPLL->POD = POD;
> -                    }
> -                }
> -            }
> -        }
> -    }
> +			pPLL->POD = POD;
> +			}
> +		}
> +		}
	     ^^^^^^^
problem with indention with this code block.
and also in some places in your patch you changed the indention of opening brace
of the for loop.
the code was:
for ( ; ; )
{

you are making it: 
for ( ; ; )
	{

well, ultimately that opening brace of switch-case, for loops and if
will go to the previous line, so i think this extra indention will not
hurt, but I am not sure. Dan Carpenter or Joe Perches or Greg can say
if this extra indention is acceptable.
But the indention problem marked just above this will not be accepted.

regards
sudip

> +	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/