linux-kernel - [PATCH 3/5] drivers/net/wireless/brcm80211/brcmsmac/stf.c: don't use unmodified return variable name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 16 Mar 2015 22:16:57 +0800
From:	Peter Teoh <htmldeveloper@...il.com>
To:	Brett Rudley <brudley@...adcom.com>,
	Arend van Spriel <arend@...adcom.com>,
	"Franky (Zhenhui) Lin" <frankyl@...adcom.com>,
	Hante Meuleman <meuleman@...adcom.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH 3/5] drivers/net/wireless/brcm80211/brcmsmac/stf.c: don't use
 unmodified return variable name

Discovered by Coccinelle.   Removed the use of variable for storing
returning values, which is un-modified / un-used throughout.

Signed-off-by: Peter Teoh <htmldeveloper@...il.com

diff -u -p a/drivers/net/wireless/brcm80211/brcmsmac/stf.c
b/drivers/net/wireless/brcm80211/brcmsmac/stf.c
--- a/drivers/net/wireless/brcm80211/brcmsmac/stf.c
+++ b/drivers/net/wireless/brcm80211/brcmsmac/stf.c
@@ -306,7 +306,6 @@ int brcms_c_stf_txchain_set(struct brcms
  */
 int brcms_c_stf_ss_update(struct brcms_c_info *wlc, struct brcms_band *band)
 {
-       int ret_code = 0;
        u8 prev_stf_ss;
        u8 upd_stf_ss;

@@ -325,7 +324,7 @@ int brcms_c_stf_ss_update(struct brcms_c
                                    PHY_TXC1_MODE_SISO : PHY_TXC1_MODE_CDD;
        } else {
                if (wlc->band != band)
-                       return ret_code;
+                       return 0;
                upd_stf_ss = (wlc->stf->txstreams == 1) ?
                                PHY_TXC1_MODE_SISO : band->band_stf_ss_mode;
        }
@@ -334,7 +333,7 @@ int brcms_c_stf_ss_update(struct brcms_c
                brcms_b_band_stf_ss_set(wlc->hw, upd_stf_ss);
        }

-       return ret_code;
+       return 0;
 }

 int brcms_c_stf_attach(struct brcms_c_info *wlc)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/