linux-kernel - [PATCH 4/5] drivers/net/wireless/brcm80211/brcmsmac/main.c: don't use unmodified return variable name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 16 Mar 2015 22:18:53 +0800
From:	Peter Teoh <htmldeveloper@...il.com>
To:	Brett Rudley <brudley@...adcom.com>,
	Arend van Spriel <arend@...adcom.com>,
	"Franky (Zhenhui) Lin" <frankyl@...adcom.com>,
	Hante Meuleman <meuleman@...adcom.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH 4/5] drivers/net/wireless/brcm80211/brcmsmac/main.c: don't use
 unmodified return variable name

Discovered by Coccinelle.   Removed the use of variable for storing
returning values, which is un-modified / un-used throughout.

Signed-off-by: Peter Teoh <htmldeveloper@...il.com

diff -u -p a/drivers/net/wireless/brcm80211/brcmsmac/main.c
b/drivers/net/wireless/brcm80211/brcmsmac/main.c
--- a/drivers/net/wireless/brcm80211/brcmsmac/main.c
+++ b/drivers/net/wireless/brcm80211/brcmsmac/main.c
@@ -3777,7 +3777,6 @@ static void brcms_c_set_ps_ctrl(struct b
  */
 static int brcms_c_set_mac(struct brcms_bss_cfg *bsscfg)
 {
-       int err = 0;
        struct brcms_c_info *wlc = bsscfg->wlc;

        /* enter the MAC addr into the RXE match registers */
@@ -3785,7 +3784,7 @@ static int brcms_c_set_mac(struct brcms_

        brcms_c_ampdu_macaddr_upd(wlc);

-       return err;
+       return 0;
 }

 /* Write the BSS config's BSSID address to core (set_bssid in d11procs.tcl).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/