linux-kernel - Re: [PATCH 14/14] drivers/tty/vt/vt.c : access out-of-bounds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150316142229.0b2145ad@lxorguk.ukuu.org.uk>
Date:	Mon, 16 Mar 2015 14:22:29 +0000
From:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
To:	Ameen Ali <ameenali023@...il.com>
Cc:	jslaby@...e.cz, tiwai@...e.de, joe@...ches.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/14] drivers/tty/vt/vt.c : access out-of-bounds

On Sat, 14 Mar 2015 14:46:22 +0200
Ameen Ali <ameenali023@...il.com> wrote:

> make sure that out-of-bounds never happens
> 
> Signed-off-by : Ameen Ali <AmeenAli023@...il.com>
> ---
>  drivers/tty/vt/vt.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> index 6e00572..cf73e92 100644
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -1364,13 +1364,13 @@ static void csi_m(struct vc_data *vc)
>  				i++;
>  				if (i > vc->vc_npar)
>  					break;

It's checked in advance    ^^^^^^^^^^^^^^^^^^^^^^^^^^


I guess whatever tool you used to verify it is concerned about the case
of i == vc->vc_npar ?

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/