linux-kernel - Re: [PATCH v4 2/4] mmc: core: Add mmc_regulator_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=U-YnT5jF5MFC==hANXGPqVpV3iLMPu85TrQ4dNDsWeCA@mail.gmail.com>
Date:	Mon, 16 Mar 2015 08:12:43 -0700
From:	Doug Anderson <dianders@...omium.org>
To:	Ulf Hansson <ulf.hansson@...aro.org>
Cc:	Heiko Stuebner <heiko@...ech.de>,
	Jaehoon Chung <jh80.chung@...sung.com>,
	Seungwon Jeon <tgih.jun@...sung.com>,
	Mark Brown <broonie@...nel.org>,
	Alexandru Stan <amstan@...omium.org>,
	Alim Akhtar <alim.akhtar@...sung.com>,
	Sonny Rao <sonnyrao@...omium.org>,
	Andrew Bresticker <abrestic@...omium.org>,
	Addy Ke <addy.ke@...k-chips.com>,
	Javier Martinez Canillas <javier.martinez@...labora.co.uk>,
	"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Chris Ball <chris@...ntf.net>,
	Johan Rudholm <johan.rudholm@...s.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Tim Kryger <tim.kryger@...il.com>,
	Andrew Gabbasov <andrew_gabbasov@...tor.com>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 2/4] mmc: core: Add mmc_regulator_set_vqmmc()

Ulf,

On Mon, Mar 16, 2015 at 7:05 AM, Ulf Hansson <ulf.hansson@...aro.org> wrote:
>> +       switch (ios->signal_voltage) {
>> +       case MMC_SIGNAL_VOLTAGE_120:
>> +               return mmc_regulator_set_voltage_if_supported(mmc->supply.vqmmc,
>> +                       1200000, 100000);
>
> Is 1V the lowest possible value? How did you get to that?

I think you've added a zero in your mind and not realized that I'm
calling regulator_set_voltage_tol() here and in other calls.  Please
read the above as:

* Try to set the voltage to exactly 1,200,000 uV (1.2V).
* If you can't get 1.2V exactly, a tolerance ("tol") of 100,000 uV
(.1V) is OK.
* In other words, 1.1V - 1.3V are OK, but aim for 1.2V


>> +       case MMC_SIGNAL_VOLTAGE_180:
>> +               return mmc_regulator_set_voltage_if_supported(mmc->supply.vqmmc,
>> +                       1800000, 100000);
>
> Is 1V the lowest possible value? How did you get to that?

Again, check my zeros.  This should be 1.7 - 1.9V, aiming for 1.8V.


>> +       case MMC_SIGNAL_VOLTAGE_330:
>> +               return mmc_regulator_set_voltage_if_supported(mmc->supply.vqmmc,
>> +                       regulator_get_voltage(mmc->supply.vmmc), 300000);
>
> Why 3V? Shouldn't it be 2.7V? How will else those SoC that for example
> supports 2.9V only work?

This will get us within .3V of whatever vmmc is.  If vmmc is 3.3V, it
will allow vqmmc of 3.0V - 3.6V.

This _seems_ sane to me and given any sane system design we should be
fine here, I think.  I can't see someone designing a system where
vqmmc was not within .3V of vmmc, can you?  If we think someone will
actually build a system where vmmc is 3.3V and vqmmc can't go higher
than 2.7V then we'll either need to increase the tolerance here or add
a new asymmetric system call like my original patches did.

>>  int mmc_regulator_get_supply(struct mmc_host *mmc);
>
> One more thought,s as for the vmmc regulator we have a
> "regulator_enabled" member in the mmc_host. Should we add a similar
> member for vqmmc? That would prevent host drivers from keeping track
> of this state themselves.

Yeah, that does sound nice.  Are you suggesting that I modify this
patch or submit a new one.  Let me know.


-Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/