linux-kernel - [PATCH 1/5] mcs7780.c: don't use unmodified return variable name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 16 Mar 2015 22:13:30 +0800
From:	Peter Teoh <htmldeveloper@...il.com>
To:	LKML <linux-kernel@...r.kernel.org>,
	Samuel Ortiz <samuel@...tiz.org>
Subject: [PATCH 1/5] mcs7780.c: don't use unmodified return variable name

Discovered by Coccinelle.   Removed the use of variable for storing
returning values, which is un-modified / un-used throughout.

Signed-off-by: Peter Teoh <htmldeveloper@...il.com>

diff -u -p a/drivers/net/irda/mcs7780.c b/drivers/net/irda/mcs7780.c
--- a/drivers/net/irda/mcs7780.c
+++ b/drivers/net/irda/mcs7780.c
@@ -669,7 +669,6 @@ static int mcs_net_ioctl(struct net_devi
 /* Network device is taken down, done by "ifconfig irda0 down" */
 static int mcs_net_close(struct net_device *netdev)
 {
-       int ret = 0;
        struct mcs_cb *mcs = netdev_priv(netdev);

        /* Stop transmit processing */
@@ -688,7 +687,7 @@ static int mcs_net_close(struct net_devi
                irlap_close(mcs->irlap);

        mcs->irlap = NULL;
-       return ret;
+       return 0;
 }

 /* Network device is taken up, done by "ifconfig irda0 up" */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/