linux-kernel - Re: [PATCH 12/32] hexagon: copy_thread(): rename 'arg' argument to 'kthread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150316162518.GA15501@codeaurora.org>
Date:	Mon, 16 Mar 2015 11:25:18 -0500
From:	rkuo <rkuo@...eaurora.org>
To:	Alex Dowad <alexinbeijing@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	"open list:QUALCOMM HEXAGON..." <linux-hexagon@...r.kernel.org>
Subject: Re: [PATCH 12/32] hexagon: copy_thread(): rename 'arg' argument to
 'kthread_arg'

On Fri, Mar 13, 2015 at 08:14:35PM +0200, Alex Dowad wrote:
> The 'arg' argument to copy_thread() is only ever used when forking a new
> kernel thread. Hence, rename it to 'kthread_arg' for clarity (and consistency
> with do_fork() and other arch-specific implementations of copy_thread()).
> 
> Signed-off-by: Alex Dowad <alexinbeijing@...il.com>
> ---
>  arch/hexagon/kernel/process.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/hexagon/kernel/process.c b/arch/hexagon/kernel/process.c
> index 0a0dd5c..6f27358 100644
> --- a/arch/hexagon/kernel/process.c
> +++ b/arch/hexagon/kernel/process.c
> @@ -71,7 +71,7 @@ unsigned long thread_saved_pc(struct task_struct *tsk)
>   * Copy architecture-specific thread state
>   */
>  int copy_thread(unsigned long clone_flags, unsigned long usp,
> -		unsigned long arg, struct task_struct *p)
> +		unsigned long kthread_arg, struct task_struct *p)
>  {
>  	struct thread_info *ti = task_thread_info(p);
>  	struct hexagon_switch_stack *ss;
> @@ -94,10 +94,11 @@ int copy_thread(unsigned long clone_flags, unsigned long usp,
>  	ss->lr = (unsigned long)ret_from_fork;
>  	p->thread.switch_sp = ss;
>  	if (unlikely(p->flags & PF_KTHREAD)) {
> +		/* kernel thread */
>  		memset(childregs, 0, sizeof(struct pt_regs));
>  		/* r24 <- fn, r25 <- arg */
>  		ss->r24 = usp;
> -		ss->r25 = arg;
> +		ss->r25 = kthread_arg;
>  		pt_set_kmode(childregs);
>  		return 0;
>  	}
> -- 
> 2.0.0.GIT
> 

Acked-by: Richard Kuo <rkuo@...eaurora.org>



-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, 
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/