linux-kernel - Re: [PATCH] kernfs: handle poll correctly on 'direct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150316163014.GA8353@htj.duckdns.org>
Date:	Mon, 16 Mar 2015 12:30:14 -0400
From:	Tejun Heo <tj@...nel.org>
To:	NeilBrown <neilb@...e.de>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, Prakash Punnoor <prakash@...noor.de>,
	Torsten Kaiser <just.for.lkml@...glemail.com>,
	linux RAID <linux-raid@...r.kernel.org>
Subject: Re: [PATCH] kernfs: handle poll correctly on 'direct_read' files.

On Mon, Mar 16, 2015 at 10:44:52AM +1100, NeilBrown wrote:
> 
> 
> Kernfs supports two styles of read: direct_read and seqfile_read.
> 
> The latter supports 'poll' correctly thanks to the update of
> '->event' in kernfs_seq_show.
> The former does not as '->event' is never updated on a read.
> 
> So add an appropriate update in kernfs_file_direct_read().
> 
> This was noticed because some 'md' sysfs attributes were
> recently changed to use direct reads.
> 
> Reported-by: Prakash Punnoor <prakash@...noor.de>
> Reported-by: Torsten Kaiser <just.for.lkml@...glemail.com>
> Fixes: 750f199ee8b578062341e6ddfe36c59ac8ff2dcb

This fixes tag is kinda weird without further explanation.

> Signed-off-by: NeilBrown <neilb@...e.de>

Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/