linux-kernel - Re: [Patch v4 2/2] dmaengine: Add ADM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150317050415.GB28722@qualcomm.com>
Date:	Tue, 17 Mar 2015 00:04:15 -0500
From:	Andy Gross <agross@...eaurora.org>
To:	sricharan@...eaurora.org
Cc:	Vinod Koul <vinod.koul@...el.com>, devicetree@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
	Bjorn Andersson <bjorn.andersson@...ymobile.com>,
	Kumar Gala <galak@...eaurora.org>, dmaengine@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [Patch v4 2/2] dmaengine: Add ADM driver

On Mon, Mar 16, 2015 at 08:15:26AM -0000, sricharan@...eaurora.org wrote:
> Hi,
> 
> <snip>
> >
> >>
> >> > +static int adm_get_blksize(unsigned int burst)
> >> > +{
> >> > +	int ret;
> >> > +
> >> > +	switch (burst) {
> >> > +	case 16:
> >> > +		ret = 0;
> >> > +		break;
> >> > +	case 32:
> >> > +		ret = 1;
> >> > +		break;
> >> > +	case 64:
> >> > +		ret = 2;
> >> > +		break;
> >> > +	case 128:
> >> > +		ret = 3;
> >> > +		break;
> >> > +	case 192:
> >> > +		ret = 4;
> >> > +		break;
> >> > +	case 256:
> >> > +		ret = 5;
> >> > +		break;
> >> ffs(burst>>4) ?
> >
> > that should work nicely.  thanks.
> >
>   Will not work for 192, 256 ?

you are right.  I'll have to separate those out into 2 more cases.  Good catch!

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/