linux-kernel - Re: [PATCH 27/35 linux-next] reset: sti: constify of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5507E240.2070109@st.com>
Date:	Tue, 17 Mar 2015 09:13:52 +0100
From:	Patrice Chotard <patrice.chotard@...com>
To:	Fabian Frederick <fabf@...net.be>, <linux-kernel@...r.kernel.org>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Srinivas Kandagatla <srinivas.kandagatla@...il.com>,
	Maxime Coquelin <maxime.coquelin@...com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	<linux-arm-kernel@...ts.infradead.org>, <kernel@...inux.com>
Subject: Re: [PATCH 27/35 linux-next] reset: sti: constify of_device_id array

Hi Fabian

On 03/16/2015 08:54 PM, Fabian Frederick wrote:
> of_device_id is always used as const.
> (See driver.of_match_table and open firmware functions)
>
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>   drivers/reset/sti/reset-stih407.c | 2 +-
>   drivers/reset/sti/reset-stih415.c | 2 +-
>   drivers/reset/sti/reset-stih416.c | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/reset/sti/reset-stih407.c b/drivers/reset/sti/reset-stih407.c
> index d83db5d7..e250604 100644
> --- a/drivers/reset/sti/reset-stih407.c
> +++ b/drivers/reset/sti/reset-stih407.c
> @@ -126,7 +126,7 @@ static const struct syscfg_reset_controller_data stih407_picophyreset_controller
>   	.channels = stih407_picophyresets,
>   };
>   
> -static struct of_device_id stih407_reset_match[] = {
> +static const struct of_device_id stih407_reset_match[] = {
>   	{
>   		.compatible = "st,stih407-powerdown",
>   		.data = &stih407_powerdown_controller,
> diff --git a/drivers/reset/sti/reset-stih415.c b/drivers/reset/sti/reset-stih415.c
> index 8dad603..fd84238 100644
> --- a/drivers/reset/sti/reset-stih415.c
> +++ b/drivers/reset/sti/reset-stih415.c
> @@ -89,7 +89,7 @@ static struct syscfg_reset_controller_data stih415_softreset_controller = {
>   	.channels = stih415_softresets,
>   };
>   
> -static struct of_device_id stih415_reset_match[] = {
> +static const struct of_device_id stih415_reset_match[] = {
>   	{ .compatible = "st,stih415-powerdown",
>   	  .data = &stih415_powerdown_controller, },
>   	{ .compatible = "st,stih415-softreset",
> diff --git a/drivers/reset/sti/reset-stih416.c b/drivers/reset/sti/reset-stih416.c
> index 79aed70..c7ccaed 100644
> --- a/drivers/reset/sti/reset-stih416.c
> +++ b/drivers/reset/sti/reset-stih416.c
> @@ -120,7 +120,7 @@ static struct syscfg_reset_controller_data stih416_softreset_controller = {
>   	.channels = stih416_softresets,
>   };
>   
> -static struct of_device_id stih416_reset_match[] = {
> +static const struct of_device_id stih416_reset_match[] = {
>   	{ .compatible = "st,stih416-powerdown",
>   	  .data = &stih416_powerdown_controller, },
>   	{ .compatible = "st,stih416-softreset",


Acked-by: Patrice Chotard <patrice.chotard@...com>

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/