lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Mar 2015 09:56:00 +0100 From: David Herrmann <dh.herrmann@...il.com> To: Lucas De Marchi <lucas.de.marchi@...il.com> Cc: linux-kernel <linux-kernel@...r.kernel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Daniel Mack <daniel@...que.org>, Lucas De Marchi <lucas.demarchi@...el.com>, Djalal Harouni <tixxdz@...ndz.org> Subject: Re: [PATCH] kdbus: fix header guard name Hi On Tue, Mar 17, 2015 at 4:03 AM, <lucas.de.marchi@...il.com> wrote: > From: Lucas De Marchi <lucas.demarchi@...el.com> > > UAPI headers have a _UAPI_ as prefix, which is removed during > headers_install. If it's put as a suffix it will not be removed and will > be the only header with UAPI in the header guard macro. > > Signed-off-by: Lucas De Marchi <lucas.demarchi@...el.com> > --- > include/uapi/linux/kdbus.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/uapi/linux/kdbus.h b/include/uapi/linux/kdbus.h > index fc1d77d..302862f 100644 > --- a/include/uapi/linux/kdbus.h > +++ b/include/uapi/linux/kdbus.h > @@ -5,8 +5,8 @@ > * your option) any later version. > */ > > -#ifndef _KDBUS_UAPI_H_ > -#define _KDBUS_UAPI_H_ > +#ifndef _UAPI_KDBUS_H_ > +#define _UAPI_KDBUS_H_ Looks good, but lacks an update of the last line in this header: #endif /* _KDBUS_UAPI_H_ */ With this comment changed: Reviewed-by: David Herrmann <dh.herrmann@...il.com> Thanks David! > #include <linux/ioctl.h> > #include <linux/types.h> > -- > 2.3.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists