linux-kernel - Re: [PATCH] kprobes/x86: Return correct length in __copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Mar 2015 18:45:26 +0900
From:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
To:	Ingo Molnar <mingo@...nel.org>
CC:	Eugene Shatokhin <eugene.shatokhin@...alab.ru>,
	Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH] kprobes/x86: Return correct length in __copy_instruction()

(2015/03/17 0:03), Ingo Molnar wrote:
> 
> * Masami Hiramatsu <masami.hiramatsu.pt@...achi.com> wrote:
> 
>> (2015/03/09 20:19), Eugene Shatokhin wrote:
>>> On x86-64, __copy_instruction() always returns 0 (error) if the
>>> instruction uses %rip-relative addressing. This is because
>>> kernel_insn_init() is called the second time for 'insn' instance
>>> in such cases and sets all its fields to 0.
>>>
>>> Because of this, trying to place a Kprobe on such instruction will
>>> fail, register_kprobe() will return -EINVAL.
>>
>> Oops, good catch!
>>
>> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
> 
> Mind resending it with your SOB, as I wasn't Cc:-ed on the original 
> submission?

Yes, I'll do :)

Thank you,

> 
> Thanks,
> 
> 	Ingo
> 


-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@...achi.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/