linux-kernel - Re: [PATCH 33/35 linux-next] mmc: constify of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFodW1zgrQ-sd5TPO_rCa_-tm95JkwCWiGX4BCUSFqPHdg@mail.gmail.com>
Date:	Tue, 17 Mar 2015 10:49:05 +0100
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Fabian Frederick <fabf@...net.be>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Chris Ball <chris@...ntf.net>,
	Tony Prisk <linux@...sktech.co.nz>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 33/35 linux-next] mmc: constify of_device_id array

On 16 March 2015 at 20:59, Fabian Frederick <fabf@...net.be> wrote:
> of_device_id is always used as const.
> (See driver.of_match_table and open firmware functions)
>
> Signed-off-by: Fabian Frederick <fabf@...net.be>

Acked-by: Ulf Hansson <ulf.hansson@...aro.org>

> ---
>  drivers/mmc/host/mmc_spi.c   | 2 +-
>  drivers/mmc/host/wmt-sdmmc.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c
> index e4a0754..ae19d83 100644
> --- a/drivers/mmc/host/mmc_spi.c
> +++ b/drivers/mmc/host/mmc_spi.c
> @@ -1507,7 +1507,7 @@ static int mmc_spi_remove(struct spi_device *spi)
>         return 0;
>  }
>
> -static struct of_device_id mmc_spi_of_match_table[] = {
> +static const struct of_device_id mmc_spi_of_match_table[] = {
>         { .compatible = "mmc-spi-slot", },
>         {},
>  };
> diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c
> index dd2e1aa..5af0055 100644
> --- a/drivers/mmc/host/wmt-sdmmc.c
> +++ b/drivers/mmc/host/wmt-sdmmc.c
> @@ -744,7 +744,7 @@ static struct wmt_mci_caps wm8505_caps = {
>         .max_blk_size = 2048,
>  };
>
> -static struct of_device_id wmt_mci_dt_ids[] = {
> +static const struct of_device_id wmt_mci_dt_ids[] = {
>         { .compatible = "wm,wm8505-sdhc", .data = &wm8505_caps },
>         { /* Sentinel */ },
>  };
> --
> 2.1.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/