linux-kernel - Re: [PATCH] phy: omap-usb2: Fix missing clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 17 Mar 2015 12:21:09 +0200
From:	Roger Quadros <rogerq@...com>
To:	Axel Lin <axel.lin@...ics.com>,
	Kishon Vijay Abraham I <kishon@...com>
CC:	Felipe Balbi <balbi@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"3.9+" <stable@...r.kernel.org>
Subject: Re: [PATCH] phy: omap-usb2: Fix missing clk_prepare call when using
 old dt name

+stable, v3.16+

On 11/03/15 03:41, Axel Lin wrote:
> Current code does not call clk_prepare(phy->optclk) when using the old
> usb_otg_ss_refclk960m name. Fix it.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>

Acked-by: Roger Quadros <rogerq@...com>

cheers,
-roger

> ---
>  drivers/phy/phy-omap-usb2.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/phy/phy-omap-usb2.c b/drivers/phy/phy-omap-usb2.c
> index 6f4aef3..dcdd850 100644
> --- a/drivers/phy/phy-omap-usb2.c
> +++ b/drivers/phy/phy-omap-usb2.c
> @@ -296,10 +296,11 @@ static int omap_usb2_probe(struct platform_device *pdev)
>  			dev_warn(&pdev->dev,
>  				 "found usb_otg_ss_refclk960m, please fix DTS\n");
>  		}
> -	} else {
> -		clk_prepare(phy->optclk);
>  	}
>  
> +	if (!IS_ERR(phy->optclk))
> +		clk_prepare(phy->optclk);
> +
>  	usb_add_phy_dev(&phy->phy);
>  
>  	return 0;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/