linux-kernel - Re: [PATCH 1/2] staging: ft1000: remove unused variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 17 Mar 2015 18:22:38 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Marek Belisko <marek.belisko@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] staging: ft1000: remove unused variables

On Mon, Mar 16, 2015 at 04:33:02PM +0100, Greg KH wrote:
> On Sat, Mar 07, 2015 at 10:56:52AM +0530, Sudip Mukherjee wrote:
> > these variables were assigned some values but they were never being
> > reused again.
> 
> But some of them should have been checked, right?  Or, if no one cares,
> fix up the function to not return anything, like for all of the
> read_register() calls.
> 
> Please do that instead.
but the return value of ft1000_read_register() is being used in
some places like card_send_command() or in ft1000_ioctl().
we can use the return value (if error) in the poll() or ioctl()
instead of returning -1 or -ENOTTY. but in the other places,
its - no one cares.

regards
sudip

> 
> thanks,
> 
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/