linux-kernel - Re: [PATCH v2 1/1] usb: xhci: apply XHCI_AVOID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 17 Mar 2015 16:21:27 +0100
From:	Alistair Grant <akgrant0710@...il.com>
To:	Mathias Nyman <mathias.nyman@...el.com>,
	Lu Baolu <baolu.lu@...ux.intel.com>,
	Mathias Nyman <mathias.nyman@...ux.intel.com>
Cc:	Devin Heitmueller <dheitmueller@...nellabs.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] usb: xhci: apply XHCI_AVOID_BEI quirk to all Intel
 xHCI controllers

On Mon, Mar 16, 2015 at 5:29 PM, Mathias Nyman <mathias.nyman@...el.com> wrote:
> On 16.03.2015 17:21, Alistair Grant wrote:
>> On Mon, Mar 16, 2015 at 3:47 PM, Mathias Nyman <mathias.nyman@...el.com> wrote:
>>> On 16.03.2015 16:31, Alistair Grant wrote:
>>>> On Mon, Mar 16, 2015 at 1:55 PM, Mathias Nyman
>>>> <mathias.nyman@...ux.intel.com> wrote:
>>>>> On 15.03.2015 21:18, Alistair Grant wrote:
>>>>>> On Sun, Mar 15, 2015 at 3:54 PM, Alistair Grant <akgrant0710@...il.com> wrote:
>>>>>> ...
>>>>>> It looks like I may have signed-off a little too soon.  While the patch is
>>>>>> working correctly if the Hauppauge Live2 is plugged in after the system has
>>>>>> booted and settled down (my normal use case), it fails if the Live2 is
>>>>>> plugged in while the system is booted up.
>>>>>>
>>>>>> Unplugging the Live2 after recording (which appears to succeed from the
>>>>>> command line, but had no audio), executing lsusb just hangs.
>>>>>>
>>>>>> I've included what I think is the relevant portions of /var/log/syslog
>>>>>> below.  If you'd like the entire log file posted somewhere please let me
>>>>>> know.
>>>>>
>>>>> Hi
>>>>>
>>>>> What kernel did you try this patch on?
>>>>>
>>>>> The output look a bit like the regression in 4.0-rc3 caused by:
>>>>> commit 27082e2654dc148078b0abdfc3c8e5ccbde0ebfa
>>>>>     xhci: Clear the host side toggle manually when endpoint is 'soft reset'
>>>>>
>>>>> which will be reverted (in 4.0-rc5 I hope).
>>>>>
>>>>> If you boot the same base kernel without the patch does it work then?
>>>>>
>>>>> -Mathias
>>>>>
>>>>
>>>> Hi Mathias,
>>>>
>>>> This is on top of 3.19.1 with only the XHCI_AVOID_BEI quirk patch applied.
>>>>
>>>> If you'd like me to try it against 4.0-rc3, 4 or 5, please let me know.
>>>
>>> Thanks, no that's not needed.
>>> But did the patch cause regression on top of 3.19.1?
>>> I mean, did it make 3.19.1  worse, better or just different for you, while
>>> booting with the device connected?
>>
>> Recording doesn't work at all with 3.19.1 without the patch.  I've
>> included an extract from syslog below of attempting to record with a
>> clean 3.19.1 system (i.e. XHCI_AVOID_BEI quirk patch NOT applied, to
>> state the obvious).
>>
>> I did mean to say in my original message that I would still release
>> this patch even with the current known issue as it still improves the
>> overall stability of the system.
>>
>
> Ok, thanks
> I'll add it to the queue

Hi Mathias & Lu,

FYI...  I also tried booting with the Live2 plugged in with the
following kernel:

* 3.19.1
* usb: xhci: apply XHCI_AVOID_BEI quirk to all Intel xHCI controllers
* xhci: Allocate correct amount of scratchpad buffers
* xhci.h: Increase TRBS_PER_SEGMENT from 64 to 256

i.e. add the scratchpad buffers fix and increase TRBS_PER_SEGMENT,
however the problem still occurs if the Live2 is plugged in during
boot up.

Thanks,
Alistair
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/