linux-kernel - RE: Possible no longer required cast in the function,usbhs_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN3PR0301MB08490DB516C5E9EFEEA6BC9481030@BN3PR0301MB0849.namprd03.prod.outlook.com>
Date:	Tue, 17 Mar 2015 03:37:42 +0000
From:	Peter Chen <Peter.Chen@...escale.com>
To:	nick <xerofoify@...il.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:	"balbi@...com" <balbi@...com>,
	"ergei.shtylyov@...entembedded.com" 
	<ergei.shtylyov@...entembedded.com>,
	"varkab@...c.in" <varkab@...c.in>,
	"yoshihiro.shimoda.uh@...esas.com" <yoshihiro.shimoda.uh@...esas.com>,
	"ulrich.hecht@...il.com" <ulrich.hecht@...il.com>,
	"takeshi.kihara.df@...esas.com" <takeshi.kihara.df@...esas.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: Possible  no longer required cast in the function,usbhs_parse_dt
 in common.c

 
> 
> Greetings All,
> I have been getting the below build warnings:
> drivers/usb/renesas_usbhs/common.c: In function ‘usbhs_parse_dt’:
> drivers/usb/renesas_usbhs/common.c:482:25: warning: cast from pointer to
> integer of different size [-Wpointer-to-int-cast]
> dparam->type = of_id ? (u32)of_id->data : 0;
> After looking into the function I am curious if the hardware is only 32 bit as if
> the supported hardware for this driver is then this cast is no longer required
> and I can send in a patch removing it. Furthermore, sorry for the simple
> question but  I don't have access to the device specs for supported hardware
> so I though it would be better to ask before I send in patch fixing this issue.
> Thanks,
> Nick

Patch is welcome, there will be comment if it is not suitable.

Peter