linux-kernel - Re: [PATCH 2/2] add newhaven lcd tty driver on i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150317211605.GB8441@kroah.com>
Date:	Tue, 17 Mar 2015 22:16:05 +0100
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Alan Tull <atull@...nsource.altera.com>
Cc:	Jiri Slaby <jslaby@...e.cz>, Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, delicious.quinoa@...il.com,
	dinguyen@...nsource.altera.com, yvanderv@...nsource.altera.com
Subject: Re: [PATCH 2/2] add newhaven lcd tty driver on i2c

On Tue, Mar 17, 2015 at 03:36:47PM -0500, Alan Tull wrote:
> Supports the Newhaven NHD‐0216K3Z‐NSW‐BBW 2x16 LCD module as i2c slave.
> Devices will show up as /dev/ttyLCD0, etc.
> 
>  * Backspace is supported to the beginning of the current line.
>     * i.e. printf '\b' > /dev/ttyLCD0
> 
>  * ESC [ 2 J
>     * erase whole display and reset cursor to home.
>     * i.e. printf '\e[2J' > /dev/ttyLCD0
> 
>  * ESC [ 2 K
>     * erase current line and set cursor to beginning of line.
>     * i.e. printf '\e[2K' > /dev/ttyLCD0
> 
>  * CR and LF are supported.
> 
>  * Vertical scroll when cursor is on bottom line and receive end of line.
> 
> Default brightness can be set from the device tree/plat data.
> 
> Brightness can be set from a sysfs file, for example:
>  * echo 6 > /sys/devices/soc.0/ffc04000.i2c/i2c-0/0-0028/brightness
> 
> Signed-off-by: Alan Tull <atull@...nsource.altera.com>

This should use the new fb_tft api instead of trying to look like a tty
device.  That framework is merged in the staging-next branch of the
staging.git kernel tree and will show up in 4.1-rc1.  Please port this
driver to that api and submit a patch for me to take for the staging
tree so that we don't have one-off devices like this.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/