linux-kernel - Re: [PATCH v14 19/20] vfio: initialize the virqfd workqueue in VFIO generic code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1426631368.3643.348.camel@redhat.com>
Date:	Tue, 17 Mar 2015 16:29:28 -0600
From:	Alex Williamson <alex.williamson@...hat.com>
To:	Baptiste Reynal <b.reynal@...tualopensystems.com>
Cc:	iommu@...ts.linux-foundation.org, kvmarm@...ts.cs.columbia.edu,
	tech@...tualopensystems.com,
	Antonios Motakis <a.motakis@...tualopensystems.com>,
	Gavin Shan <gwshan@...ux.vnet.ibm.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Alexey Kardashevskiy <aik@...abs.ru>,
	Wei Yang <weiyang@...ux.vnet.ibm.com>,
	"open list:VFIO DRIVER" <kvm@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v14 19/20] vfio: initialize the virqfd workqueue in VFIO
 generic code

On Mon, 2015-03-02 at 17:59 +0100, Baptiste Reynal wrote:
> From: Antonios Motakis <a.motakis@...tualopensystems.com>
> 
> Now we have finally completely decoupled virqfd from VFIO_PCI. We can
> initialize it from the VFIO generic code, in order to safely use it from
> multiple independent VFIO bus drivers.
> 
> Signed-off-by: Antonios Motakis <a.motakis@...tualopensystems.com>
> Signed-off-by: Baptiste Reynal <b.reynal@...tualopensystems.com>
> ---
>  drivers/vfio/Makefile       | 4 +++-
>  drivers/vfio/pci/Makefile   | 3 +--
>  drivers/vfio/pci/vfio_pci.c | 8 --------
>  drivers/vfio/vfio.c         | 8 ++++++++
>  4 files changed, 12 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/vfio/Makefile b/drivers/vfio/Makefile
> index dadf0ca..d798b09 100644
> --- a/drivers/vfio/Makefile
> +++ b/drivers/vfio/Makefile
> @@ -1,4 +1,6 @@
> -obj-$(CONFIG_VFIO) += vfio.o
> +vfio_core-y := vfio.o virqfd.o
> +
> +obj-$(CONFIG_VFIO) += vfio_core.o
>  obj-$(CONFIG_VFIO_IOMMU_TYPE1) += vfio_iommu_type1.o
>  obj-$(CONFIG_VFIO_IOMMU_SPAPR_TCE) += vfio_iommu_spapr_tce.o
>  obj-$(CONFIG_VFIO_SPAPR_EEH) += vfio_spapr_eeh.o

This inadvertently (I assume) renames the main vfio module to vfio_core.
That potentially breaks numerous userspace scripts that might try to
load the "vfio" module.  I don't think that's acceptable.  A brute force
way to fix this would be to rename vfio.c to vfio_core.c and change the
Makefile to:

vfio-y := vfio_core.o virqfd.o
obj-$(CONFIG_VFIO) += vfio.o

Is there any other trickery available to us that could include virqfd.o
in vfio.o w/o source file renaming?  Thanks,

Alex

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/