linux-kernel - Re: Possible no longer required cast in the function,usbhs_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20150317041419.GB31114@saruman.tx.rr.com>
Date:	Mon, 16 Mar 2015 23:14:19 -0500
From:	Felipe Balbi <balbi@...com>
To:	nick <xerofoify@...il.com>
CC:	<balbi@...com>, Peter Chen <Peter.Chen@...escale.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"ergei.shtylyov@...entembedded.com" 
	<ergei.shtylyov@...entembedded.com>,
	"varkab@...c.in" <varkab@...c.in>,
	"yoshihiro.shimoda.uh@...esas.com" <yoshihiro.shimoda.uh@...esas.com>,
	"ulrich.hecht@...il.com" <ulrich.hecht@...il.com>,
	"takeshi.kihara.df@...esas.com" <takeshi.kihara.df@...esas.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: Possible  no longer required cast in the function,usbhs_parse_dt
 in common.c

On Tue, Mar 17, 2015 at 12:10:41AM -0400, nick wrote:
> 
> 
> On 2015-03-16 11:56 PM, nick wrote:
> > 
> > 
> > On 2015-03-16 11:54 PM, Felipe Balbi wrote:
> >> On Mon, Mar 16, 2015 at 11:51:15PM -0400, nick wrote:
> >>>
> >>>
> >>> On 2015-03-16 11:37 PM, Peter Chen wrote:
> >>>>  
> >>>>>
> >>>>> Greetings All,
> >>>>> I have been getting the below build warnings:
> >>>>> drivers/usb/renesas_usbhs/common.c: In function ‘usbhs_parse_dt’:
> >>>>> drivers/usb/renesas_usbhs/common.c:482:25: warning: cast from pointer to
> >>>>> integer of different size [-Wpointer-to-int-cast]
> >>>>> dparam->type = of_id ? (u32)of_id->data : 0;
> >>>>> After looking into the function I am curious if the hardware is only 32 bit as if
> >>>>> the supported hardware for this driver is then this cast is no longer required
> >>>>> and I can send in a patch removing it. Furthermore, sorry for the simple
> >>>>> question but  I don't have access to the device specs for supported hardware
> >>>>> so I though it would be better to ask before I send in patch fixing this issue.
> >>>>> Thanks,
> >>>>> Nick
> >>>>
> >>>> Patch is welcome, there will be comment if it is not suitable.
> >>>>
> >>>> Peter
> >>>>
> >>> I understand that,my question was does the hardware for this driver support 64 bit.
> >>
> >> regardless, it shouldn't produce a build warning.
> >>
> > It does for me.
> > Nick
> > 
> After looking more closely it seems me are trying to convert a const
> void to a int. Does the data member need to be const as this may be
> causing the issue.

why would const have anything to do with sizes ?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)