linux-kernel - RE: [PATCH v2.0 1/2] pm: at91: add the PM initialization for the sama5d3 and sama5d4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <B256D81BAE5131468A838E5D7A243641BFD932FE@penmbx01>
Date:	Wed, 18 Mar 2015 00:52:42 +0000
From:	"Yang, Wenyou" <Wenyou.Yang@...el.com>
To:	Sylvain Rochet <sylvain.rochet@...secur.com>
CC:	"Ferre, Nicolas" <Nicolas.FERRE@...el.com>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"alexandre.belloni@...e-electrons.com" 
	<alexandre.belloni@...e-electrons.com>,
	"peda@...ntia.se" <peda@...ntia.se>,
	"sergei.shtylyov@...entembedded.com" 
	<sergei.shtylyov@...entembedded.com>,
	"linux@...im.org.za" <linux@...im.org.za>
Subject: RE: [PATCH v2.0 1/2] pm: at91: add the PM initialization for the
 sama5d3 and sama5d4

Hi Sylvain,

> -----Original Message-----
> From: Sylvain Rochet [mailto:sylvain.rochet@...secur.com]
> Sent: 2015年3月16日 18:21
> To: Yang, Wenyou
> Cc: Ferre, Nicolas; linux@....linux.org.uk; linux-arm-kernel@...ts.infradead.org;
> linux-kernel@...r.kernel.org; alexandre.belloni@...e-electrons.com;
> peda@...ntia.se; sergei.shtylyov@...entembedded.com; linux@...im.org.za
> Subject: Re: [PATCH v2.0 1/2] pm: at91: add the PM initialization for the sama5d3
> and sama5d4
> 
> Hello Wenyou,
> 
> On Mon, Mar 09, 2015 at 11:57:08AM +0800, Wenyou Yang wrote:
> > To get the mpddrc peripheral id from the PM initialization, which will
> > be used to disable mpddrc'c clock during suspending.
> 
> > +void __init sam5d3_pm_init(void)
> > +{
> > +	at91_dt_ramc();
> > +	at91_pm_data.uhp_udp_mask = AT91SAM926x_PMC_UHP |
> AT91SAM926x_PMC_UDP;
> > +	at91_pm_data.memctrl = AT91_MEMCTRL_DDRSDR;
> > +	at91_pm_data.ddrc_pid = SAMA5D3_ID_MPDDRC;
> > +	return at91_pm_init();
> > +}
> > +
> > +void __init sam5d4_pm_init(void)
> > +{
> > +	at91_dt_ramc();
> > +	at91_pm_data.uhp_udp_mask = AT91SAM926x_PMC_UHP |
> AT91SAM926x_PMC_UDP;
> > +	at91_pm_data.memctrl = AT91_MEMCTRL_DDRSDR;
> > +	at91_pm_data.ddrc_pid = SAMA5D4_ID_MPDDRC;
> > +	at91_pm_data.is_sama5d4 = true;
> > +	return at91_pm_init();
> > +}
> 
> > +static void __init sama5d4_dt_device_init(void) {
> > +	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> > +	sam5d4_pm_init();
> > +}
> 
> This doesn't look right, where is sam5d3_pm_init() actually used ?
Oh, I missed it mindlessly during rebasing. I will added it in the next version. 

Sorry for being confused. 

> 
> Sylvain

Best Regards,
Wenyou Yang