| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 18 Mar 2015 11:50:25 +0100
From: Vitaly Kuznetsov <vkuznets@...hat.com>
To: Lorenzo Stoakes <lstoakes@...il.com>
Cc: sudipm.mukherjee@...il.com, teddy.wang@...iconmotion.com,
gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset
Lorenzo Stoakes <lstoakes@...il.com> writes:
> This patch uses memset_io instead of memset when using memset on __iomem
> qualified pointers. This fixes the following sparse warnings:-
>
> drivers/staging/sm750fb/sm750.c:489:17: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/sm750fb/sm750.c:490:17: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/sm750fb/sm750.c:501:17: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/sm750fb/sm750.c:502:17: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/sm750fb/sm750.c:833:5: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/sm750fb/sm750.c:1154:9: warning: incorrect type in argument 1 (different address spaces)
>
> Signed-off-by: Lorenzo Stoakes <lstoakes@...il.com>
> ---
> drivers/staging/sm750fb/sm750.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index aa0888c..3e36b6a 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -486,8 +486,8 @@ static int lynxfb_resume(struct pci_dev* pdev)
> par = info->par;
> crtc = &par->crtc;
> cursor = &crtc->cursor;
> - memset(cursor->vstart, 0x0, cursor->size);
> - memset(crtc->vScreen,0x0,crtc->vidmem_size);
> + memset_io(cursor->vstart, 0x0, cursor->size);
> + memset_io(crtc->vScreen,0x0,crtc->vidmem_size);
ERROR is reported by scripts/checkpatch.pl (spaces are missing after
','). This coding style problem was there before your patch but I don't
think it makes sense to preserve it.
> lynxfb_ops_set_par(info);
> fb_set_suspend(info, 0);
> }
> @@ -498,8 +498,8 @@ static int lynxfb_resume(struct pci_dev* pdev)
> par = info->par;
> crtc = &par->crtc;
> cursor = &crtc->cursor;
> - memset(cursor->vstart, 0x0, cursor->size);
> - memset(crtc->vScreen,0x0,crtc->vidmem_size);
> + memset_io(cursor->vstart, 0x0, cursor->size);
> + memset_io(crtc->vScreen,0x0,crtc->vidmem_size);
the same
> lynxfb_ops_set_par(info);
> fb_set_suspend(info, 0);
> }
> @@ -830,7 +830,7 @@ static int lynxfb_set_fbinfo(struct fb_info* info,int index)
>
> crtc->cursor.share = share;
> - memset(crtc->cursor.vstart, 0, crtc->cursor.size);
> + memset_io(crtc->cursor.vstart, 0, crtc->cursor.size);
WARNING: please, no spaces at the start of a line
#137: FILE: drivers/staging/sm750fb/sm750.c:833:
+ memset_io(crtc->cursor.vstart, 0, crtc->cursor.size);$
> if(!g_hwcursor){
> lynxfb_ops.fb_cursor = NULL;
> crtc->cursor.disable(&crtc->cursor);
> @@ -1151,7 +1151,7 @@ static int lynxfb_pci_probe(struct pci_dev * pdev,
> }
> #endif
>
> - memset(share->pvMem,0,share->vidmem_size);
> + memset_io(share->pvMem,0,share->vidmem_size);
the same missing spaces
>
> pr_info("sm%3x mmio address = %p\n",share->devid,share->pvReg);
>
> --
> 2.3.2
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
--
Vitaly
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists