linux-kernel - Re: [PATCH] spi: fsl-spi: use of_iomap() to map parameter ram on CPM1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150318120310.GH2869@sirena.org.uk>
Date:	Wed, 18 Mar 2015 12:03:10 +0000
From:	Mark Brown <broonie@...nel.org>
To:	leroy christophe <christophe.leroy@....fr>
Cc:	linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
	linux-spi@...r.kernel.org
Subject: Re: [PATCH] spi: fsl-spi: use of_iomap() to map parameter ram on CPM1

On Thu, Mar 12, 2015 at 07:52:53AM +0100, leroy christophe wrote:
> Le 06/03/2015 12:44, Mark Brown a écrit :

> >It's legacy, all that code is really old.  Modern code is written in as
> >architecture and firmware neutral a fashion as possible to make things
> >more consistent and maintainable.

> This patch is only a small bug fix.
> That driver already contains calls to of_iomap() and other related of_
> functions.
> Is it worth rewriting the driver for just a small bug fix ?

I don't think you need to fix other usages but I'd rather not introduce
new usages of legacy APIs that just need to be fixed up.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)