lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 18 Mar 2015 14:43:01 +0100 From: Quentin Lambert <lambert.quentin@...il.com> To: Dan Carpenter <dan.carpenter@...cle.com> CC: Lidza Louina <lidza.louina@...il.com>, devel@...verdev.osuosl.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, driverdev-devel@...uxdriverproject.org, kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] Staging: dgnc: release the lock before testing for nullity On 18/03/2015 14:36, Dan Carpenter wrote: > This changelog still doesn't make sense so I took a look at the code. > > tty_ldisc_deref() is an unlock function. So this is a lock ordering > bug. What makes you think the original ordering was correct? Who > reported this bug? What are the effects of this bug? I was the one who introduced the ordering change in the first place. I am just trying to fix it because although nobody complained I am not sure of the impact and restoring the previous control flow seems to be the right thing to do. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists