linux-kernel - Re: [PATCH 1/1 linux-next] mm/page_alloc.c: don't redeclare mt in get_pageblock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55098139.7090206@suse.cz>
Date:	Wed, 18 Mar 2015 14:44:25 +0100
From:	Vlastimil Babka <vbabka@...e.cz>
To:	Fabian Frederick <fabf@...net.be>, linux-kernel@...r.kernel.org
CC:	linux-mm@...ck.org
Subject: Re: [PATCH 1/1 linux-next] mm/page_alloc.c: don't redeclare mt in
 get_pageblock_migratetype()

On 03/11/2015 07:08 PM, Fabian Frederick wrote:
> mt is already declared above and global value not used after loop.
> This fixes a shadow warning.
>
> Signed-off-by: Fabian Frederick <fabf@...net.be>

Acked-by: Vlastimil Babka <vbabka@...e.cz>

> ---
>   mm/page_alloc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 1b84950..4ec8c23 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -1653,7 +1653,7 @@ int __isolate_free_page(struct page *page, unsigned int order)
>   	if (order >= pageblock_order - 1) {
>   		struct page *endpage = page + (1 << order) - 1;
>   		for (; page < endpage; page += pageblock_nr_pages) {
> -			int mt = get_pageblock_migratetype(page);
> +			mt = get_pageblock_migratetype(page);
>   			if (!is_migrate_isolate(mt) && !is_migrate_cma(mt))
>   				set_pageblock_migratetype(page,
>   							  MIGRATE_MOVABLE);
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/